[jboss-dev-forums] [Design of AOP on JBoss (Aspects/JBoss)] - Optmizing Pointcut matching in instrumentation

[flavia.rainone@jboss.com]

While doing the optimization with the BindingCollection, I thought that it would be a good idea to do the same during instrumentation.

https://jira.jboss.org/jira/browse/JBAOP-603

At that time, my idea was to create a PointcutCollection, that would have methods for retrieval of pointcuts according to their type classification (execution, call, etc). This would be similar to BindingCollection, and I was considering the possibility of replacing this collection with a parameterized ClassifiedCollection for using with both binding and pointcuts.

Now, I'm not as sure this optimization is worthy to do at this point, so close to the release. I see that Kabir has added a few checks that call the isCall, isWithin, etc, methods in AspectManager, avoiding the trigger of a transformation step when possible. Maybe those checks are enough and we don't need to retrieve classified pointcuts for transformation.

What do you think, Kabir?

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4170650#4170650

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4170650