[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1423 Test case for @RemoteBinding

[jaikiran]

I am done with the testcase. They are passing :)

"ALRubinger" wrote : 
  | Some change requests to your patch (mostly housekeeping):
  | 
  | * Add to setupBeforeClass the boilerplate for deploying *-aop.xml, 
  | example in JndiSessionRegistrarTestCaseBase (else tests will fail)
  | 

Done 

"ALRubinger" wrote : 
  | * Add tests that the explicit addresses are also unbound upon undeploy
  | 

Done.

"ALRubinger" wrote : 
  | Also, the package name / class name of the test could be more in-line with those you've done for JndiSessionRegistrarTestCaseBase; they both test pretty much the same thing, only difference is that this new one uses explicit bindings as opposed to the default.  Maybe they could be merged?  
  | 

Yes, that's a good point. 

"ALRubinger" wrote : 
  | I'd just like it to be ultra-clear what these tests do from their names alone (JndiSessionRegistrarTestCaseBase sounds pretty vauge).  Open to your suggestions here and then we'll move things around to be friendlier.
  | 

How about merging these tests into a JNDIBindingTestCase, since all these tests, check that the ejb objects are properly bound/unbound to/from JNDI?





View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4171489#4171489

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4171489