[jboss-dev-forums] [Design of OSGi Integration] - Re: Facade Questions

[adrian@jboss.org]

The use of DeploymentControllerContext and DeploymentContext in the bundle
facade is wrong. It should not be using these classes directly, they are implement details.

The clue is the name of the class. If it doesn't contain spi then it is implementation
detail that you shouldn't use directly.
"import org.jboss.deployers.plugins.deployers.DeploymentControllerContext;"

Ok the DeploymentContext does contain spi in the package name,
but that's a mistake that will go away:
http://jira.jboss.com/jira/browse/JBMICROCONT-189

For a lot of what you are doing, you should be using the DeploymentUnit anyway.
e.g. DeploymentUnit.getClassLoader()

For the state changing, we obviously need to add methods to the MainDeployer
interface (which will delegate to the DeployersImpl) 
such that you can move the deployment to different states.

You shouldn't be doing your own "housekeeping" work on the deployments.
That's not a facade. ;-)

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4132140#4132140

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4132140