[jboss-dev-forums] [Design of POJO Server] - Re: Scoping of war/jar file embedded in sar service archives

[adrian@jboss.org]

"scott.stark at jboss.org" wrote : "adinn" wrote : 
  |   | I just want to understand what the difference is. It sounds like the war manifest classpath behavior has changed, but if anything I would expect that in jbossas5 the war manifest was ignored while what you describe appears to be the opposite; that 4.X/5.0.BetaX were not using the war manifest classpath. I think we have gone around on whether the war manifest classpath should be picked up or not.
  |   | 
  | 
  | The issue is probably that the war manifest classpath should only be processed
  | when it is a top level deployment (well nearly see below :-).
  | 
  | If it is not a top level deployment, then the jars will already be included
  | in the top level deployment classloader (and should be shared
  | between the wars).
  | 
  | This logic would go in the WARStructure deployer
  | 
  | 
  |   |             // Add the war manifest classpath entries (if its top level)
  |   |             if (isTopLevel(parent))
  |   |                addClassPath(root, file, false, true, context);
  |   | 
  | 
  | However it should really also check (for non-top level deployments)
  | whether the manifest entry is included as a context within the parent.
  | 
  | e.g. an ear might not delcare the jar in application.xml, 
  | instead it is only referenced from the war manifest.
  | 
  | 
  |   |             // Add the war manifest classpath entries (if its top level)
  |   |             if (isTopLevel(parent) || doesntAlreadyHaveContext(metadata, file))
  |   |                addClassPath(root, file, false, true, context);
  |   | 
  | 
  | If you agree with my analysis, then create a JIRA issue for it.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4164192#4164192

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4164192