[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Message Chunking

[ataylor]

anonymous wrote : I have to say I don't really understand why you don't just put the conversion to List in the encode method of the Packet - not sure I see that PacketAssembler/Disassembler is necessary. 

could do, but i don't think the Packet should care about how messages are broken up.

anonymous wrote : Another observation is that messages are just being re-encoded into several buffers. The original idea here was to write directly into the messages own buffers when the user builds the message and then just use that when writing to the wire - no re-writing necessary. 

yes, at the minute they do. this still needs changing. Doing it this way tho' means that every message is still split up into 2 messages since the body is always written before the packet headers etc. I was thinking about changing it so the body is encoded at the time of sending the message.

anonymous wrote : I'm nor sure we need PacketFragment either - can't we just use MessagingBuffer? 

we need somewhere to hold the fragment info, ie packet id, correlation id etc.

anonymous wrote : Regarding re-assembling, I'm not sure this is necessary either since when reading several packets off the wire to form a command we can just store the actual buffers, no need to re-assemble?

we need to reassemble them as we need to know which packet they belong to, and need to wait for all the fragments to arrive before decoding. remember there may be fragments from many packets interleaved in a buffer.

anonymous wrote : One thing I noticed is that RemotingServiceImpl and PacketAssemblerImpl have references to a PacketFragmentCache but don't do anything with it.  This is a holder for WIP.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4167869#4167869

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4167869