[jboss-dev-forums] [Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

[adrian@jboss.org]

"alesj" wrote : "alesj" wrote : 
  |   | "adrian at jboss.org" wrote : 
  |   |   | It's strange that these are all annotation tests?????
  |   |   | 
  |   | Yup, looks like my fault. :-)
  | And this one - ClassAnnotationTestCase - is all yours. :-)
  | 
  | You are peeking MetaData in the TestClassAnnotation constructor.
  | And in the test you expect this MetaData not to be null - assertPeekedMetaData.
  | But the AOPConstructorJoinpoint masks the MetaData just before it creates the instance.
  | 

I don't really understand this? The test was added at the same time as a change
to the AOPConstructorJoinpoint (so it must have worked at some point unless
I'm stupid? :-)

The test hasn't changed since, but the joinpoint factory has changed a lot.

Choose one of:
* the test only worked by fluke and later fixes found the problem - so it started failing
and nobody raised an issue
* or the test never worked - and its been failing for 14 months without comment

Either way, it doesn't fill me confidence. ;-(

It's a stupid test anyway. The purpose is to make sure the metadata
is populated properly from the class/xml

It uses the push of the metadata (for AOP to pickup under the wire) to get this information.

It would be the same if it just did:

ControllerContext context = .assertInstalledContext("name");
ScopeKey scope = context.getScopeInfo()...;
MetaData md  = repository.getMetaData(scope);


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133919#4133919

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133919