[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Do we need JournalStorageManager::ADD_MESSAGE?

[clebert.suconic@jboss.com]

Looking at JournalStorageManager, every time you use appendAddRecord or appendUpdateRecord (transactional or not), you are aways adding the RecordType to the Byte Array.

Instead of using the ByteArray to store that information I would change the signatures on addRecord, addRecordTransaction, updateRecord, updateRecordTransaction.


Something like:

appendAddRecordTransactional(long txID, byte recordType, long id, byte[] record, IOCallback callback)

appendUpdateRecordTransactional(long txID, byte recordType, long id, byte[] record, IOCallback callback) throws Exception;

And same thing for non transactional.

(Just for the record, for obvious reasons you don't need that on delete)

I would then add the byte recordType to org.jboss.messaging.core.journal.RecordInfo.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4149522#4149522

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4149522