[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: AIO only waiting for completions on add

[clebert.suconic@jboss.com]

"timfox" wrote : A few points though on your last commit.
  | 1) Several files were missing copyright headers and class headers showing authorship. All files must have both of these before committing! I shouldn't have to keep saying this.. ;)
  | 
  | 2) Lots of cosmetic changes to files, code style, indentation, putting private public, static methods in their own sections of the file. Adding final to attributes and parameters. Making inner classes static. Making inner classes private. Making members private. Various other minor coding issues like the above.
  | 


I will change my IDE properties
"timfox" wrote : 
  | 3) Remoting timeout has changed from seconds to milliseconds? I agree we should change from s to ms, but has this been changed everywhere?
  | 

I shouldn't have changed this.


"timfox" wrote : 
  | 4) TypedProperties - the encodeSize() method traverses the entire map every time it is called. I don't like this for performance reasons. Instead the size should be maintained internally.
  | 


This is faster already than creating a Buffer and fill the buffer to guess the size ;-) We can cache the value though.

"timfox" wrote : 
  | 5) Min files was changed to 2, and file size changed from 10MB to 100 MB. 10MB was originally chosen since it seems a reasonable size to fit on a single cylinder of a disk. This allows the entire file to be accessed without moving the head. When I changed it back to 10MB and 10 files, none of the jms tests run any more reporting they can't initialise AIO (or something like that).
  | 

I shouldn't have committed this change. I will revert it if you haven't done it already.
Apart from that, looking good! :)

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4150335#4150335

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4150335