[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Some serious issues with new journal code for AIO

[timfox]

The overloaded methods that Clebert introduced, have a lot of code duplication, e.g.

public void appendAddRecordTransactional(final long txID, final byte recordType, final long id,
         final EncodingSupport record) throws Exception

and

public void appendAddRecordTransactional(final long txID, final byte recordType, final long id,
	      final byte[] record) throws Exception

Are 90% the same.

The similar parts should be refactored into a common method.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4154187#4154187

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4154187