[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Large message code review

timfox do-not-reply at jboss.com
Sat Nov 22 06:38:07 EST 2008


Another point:

ClientMessage:isLargeMessage()

ClientMessage:setLargeMessage() is only getting called for file messages, not large messages in general.

Also in ServerConsumerImpl:

Ugly instanceof check:

if (message instanceof ServerLargeMessage)
         {

Instead, how about moving isLargeMessage to the Message interface so it's implemented by both ClientMessage and ServerMessage, and it can be specified in the constructor?

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191468#4191468

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191468



More information about the jboss-dev-forums mailing list