[jboss-dev-forums] [Design the new POJO MicroContainer] - Re: Abstractions, reuse and bad examples
alesj
do-not-reply at jboss.com
Fri Oct 3 07:18:34 EDT 2008
"adrian at jboss.org" wrote :
| This is actually from the tests so its not too bad, but see below.
|
| This could obviously be made more useful to others with the following changes;
|
This deployer is only there to trigger Classpath::search w/o the real usage of facelets.
It shouldn't even be considered as a true deployer test/example.
Hence the only good/proper change would be to the javadocs,
stating its purpose, 'warning' against reuse. ;-)
"adrian at jboss.org" wrote :
| This argument is further enhanced because if you look at what
| ClassPath.search() it is wrong,
| it isn't making reference to the ClassLoadingMetaData/Module
| so it will ignore any filters.
|
| Has this code been copied somewhere else?
|
It's the Classpath class we're interested in.
And the fix to understand vfs and nested jars / resources.
This patch was ported to main facelets code.
So, there is no way to know anything about CLMD.
I agree with you that it's wrong,
but tell this to n external frameworks that make bad url assumptions. :-)
"adrian at jboss.org" wrote :
| It's generally a bad idea to show the wrong way to do things in tests
| because people copy what they find thinking that's the way it is supposed to work. :-)
I'll fix the javadocs on this. ;-)
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180256#4180256
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180256
More information about the jboss-dev-forums
mailing list