[jboss-dev-forums] [Design of JBoss ESB] - jBPM Integration - Bug and improvement ideas
camunda
do-not-reply at jboss.com
Tue Oct 14 08:03:28 EDT 2008
Hi.
I currently have a deeper look into the jBPM/ESB integration. Some things still puzzle me, and I wanted to raise two issues here because I see room for improvement ;-)
1.) Bug in JBpmCallback?
The JBpmCallback should send a signal to the one jbpm process, which triggered the ESB-Service. Right? (By the way: Some JavaDoc would be very nice here :-))
I think there is a bug in the implementation, and I didn't find a test for it, so I am not sure if it is really a bug or if I got the use case wrong:
CommandExecutor, line 127 (CALLBACK_EXECUTOR) is
EPR toEpr = message.getHeader().getCall().getTo()
Shouldn't that be
EPR toEpr = message.getHeader().getCall().getReplyTo()
The required token information is set in the replyTo EPR, and this makes sense:
EsbActionHandler:
EPR replyTo = createReplyTo(esbToBpmVarsXml, globalProcessScope, executionContext);
message.getHeader().getCall().setReplyTo(replyTo);
Or did I miss something?
2.) Codebase around CommandExecutor
The CommandExecutor class and the stuff arround it is quite hard to understand I think. It is a Command pattern (ESB: execute(message)) with a nested Command pattern (jBPM: execute(Command)). Is there a special reason for this? Why is it not done via methods (e.g. commandExecutor.executeCallback(method))? Even if that would require some if/else parsing for the OpCodes it would be much easier to understand I think. Or what do you think?
Don't get me wrong, the code overall is okay, but I find the structuring very confusing and ApiDoc are mostly missing...
Before I get dismissed, I can also volunteer for improving some of this areas :-) Since I expect to tackle a lot of these things anyway at the moment. I am committer in jBPM, so I signed the contributer agreement already, just need access to the SVN if you want to....
Let me know what you guys think about it!
Cheers
Bernd
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4182086#4182086
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4182086
More information about the jboss-dev-forums
mailing list