[jboss-dev-forums] [Design of JBoss Identity] - Re: JBoss Identity Design Preview

[jeff.yuchang]

"bdaw" wrote : This is something I was thinking about from the beginning. It can be done by keeping reference to the session in identity model classes. The main problem I see is the mix of two approaches:
  | 
  | - most management methods in the model objects (Identity/Group/Role)
  | - all management methods in manager objects connected to the session (the only reason to have 4 separate managers is to not end up with 100 methods in IdentitySession)
  | 
  | Now to mix - some methods in Identity/Group/Role and some in managers
  | 
  | Most of the search/find/resolve methods need to remain in managers anyway. Now if you think about the assignments you can place methods you mentioned in the Identity/Group but those operating on the collections will need to remain in the managers:
  | 
  | public void associateGroups(Collection<Group> parents, Collection<Group> members) throws IdentityException
  | 
  | Also you can have 
  | 
  | group.findAssociatedGroups(GroupType groupType, boolean parent, boolean inherited, ... )
  | 
  | but then you still need to keep few of findXXX methods in the manager as they don't belong to one model object... What I'm afraid of is the confusion of users where to look for certain methods. That's why I decided to put all all methods in the managers.
  | 
  | 

Exactly the issue that I am worrying about with my suggestion, thats what I mean complexity on the implementation, and say  'I just bring about this issue'. ;-(. We may keep it as it is now, cause I haven't come up a easy way to accomplish this change. Not sure others will have a better way?

-Jeff

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4184751#4184751

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4184751