[jboss-dev-forums] [Design the new POJO MicroContainer] - Re: JBMICROCONT-243 - parsing and managed objects

[scott.stark@jboss.org]

This is now JBDEPLOY-79. Another issue with the current AbstractParsingDeployerWithOutput implementation of ManagedObjectCreator is that its using the ManagedObjectFactoryBuilder.create() to obtain the ManagedObjectFactory. This is only coincidentally mapping to the ManagedObjectFactory bean now being created in the bootstrap deployers.xml, against which the BeanMetaDataICF and ServiceMetaDataICF beans register:


  |    <!-- The ManagedObjectFactory -->
  |    <bean name="ManagedObjectFactory">
  |       <constructor factoryClass="org.jboss.managed.api.factory.ManagedObjectFactory" factoryMethod="getInstance"/>
  |    </bean>
  | ...
  |    <!-- POJO Deployment -->
  |    <bean name="BeanMetaDataICF" class="org.jboss.deployers.plugins.managed.BeanMetaDataICF">
  |       <install bean="ManagedObjectFactory" method="setInstanceClassFactory">
  |          <parameter>
  |             <value>org.jboss.beans.metadata.spi.BeanMetaData</value>
  |          </parameter>
  |          <parameter>
  |             <this />
  |          </parameter>
  |       </install>
  |       <uninstall bean="ManagedObjectFactory" method="setInstanceClassFactory">
  |          <parameter>
  |             <value>org.jboss.beans.metadata.spi.BeanMetaData</value>
  |          </parameter>
  |          <parameter>
  |             <null />
  |          </parameter>
  |       </uninstall>
  |       <property name="controller"><inject bean="jboss.kernel:service=KernelController"/></property>
  |    </bean>
  | ...
  |    <!-- JMX Deployment -->
  |    <bean name="ServiceMetaDataICF" class="org.jboss.system.deployers.managed.ServiceMetaDataICF">
  |       <property name="mbeanServer"><inject bean="JMXKernel" property="mbeanServer"/></property>
  |       <install bean="ManagedObjectFactory" method="setInstanceClassFactory">
  |          <parameter>
  |             <value>org.jboss.system.metadata.ServiceMetaData</value>
  |          </parameter>
  |          <parameter>
  |             <this />
  |          </parameter>
  |       </install>
  |       <uninstall bean="ManagedObjectFactory" method="setInstanceClassFactory">
  |          <parameter>
  |             <value>org.jboss.system.metadata.ServiceMetaData</value>
  |          </parameter>
  |          <parameter>
  |             <null />
  |          </parameter>
  |       </uninstall>
  |    </bean>
  | 

I would like to break the ManagedObjectCreator into a separate DeploymentStage.INSTALLED deployer that has the ManagedObjectFactory injected into it.

Any objections?

Is this the last change to cut the JBDEPLOY-2.0.0.GA, or is a JBDEPLOY-2.0.0.CR4 needed?
  

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185438#4185438

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185438