[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: XA Recovery on Journal...

[clebert.suconic@jboss.com]

"timfox" wrote : 
  | This is related to https://jira.jboss.org/jira/browse/JBMESSAGING-1282

What I thought that should be happening, is TransactionImpl aways storing the prepare on disk. That way an empty transaction would be recovered instead of "killing" the whole branch on the TM.


   public void prepare() throws Exception
  |    {
  |       if (state != State.ACTIVE)
  |       {
  |          throw new IllegalStateException("Transaction is in invalid state " + state);
  |       }
  | 
  |       if (xid == null)
  |       {
  |          throw new IllegalStateException("Cannot prepare non XA transaction");
  |       }
  | 
  |       pageMessages();
  | 
  | //      if (containsPersistent)
  | //      {
  |          storageManager.prepare(id, xid);
  | //           Without the if (contains Persistent)
  | //      }
  | 
  |       containsPersistent = true; // just to make sure commit will also use the storageManager.
  | 
  |       state = State.PREPARED;
  |    }
  | 


I'm not sure if the journal could work with empty transactions, but that should be easily adaptable. 

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4175034#4175034

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4175034