[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1454 Encapsulate Container infomation in TO/VO

[ALRubinger]

* The patch has a series of errors in the Proxy SessionContainerTestCase, references to container.getName().  How were we handling this in InvokableContext - is "getName" valid, or should these references be using "getGuid" or "getDispatcherRegistrationName"?

* We should consider renaming "InvokableContext"; it contains a reference to JBossSessionBeanMetaData, so something denoting that this is related to sessions might be useful.  Perhaps we introduce a hierarchy, where "InvokableContext" remains generic, and "InvokableSessionContext" inherits from this and add the "getMetadata" method.

* There are some formatting-only changes in Core SessionSpecContainer.  If possible can we exclude these? :)

* Aside from that, the APIs are cleaned, all Unit Tests pass (with some fudging to work around the compiler errors mentioned above), so the only other prereq for a commit is to make sure that the Clustered Integration Tests in the EJB3 TestSuite continue to pass so that we don't give Brian a stroke.

S,
ALR



View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4176387#4176387

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4176387