[jboss-dev-forums] [Design of AOP on JBoss (Aspects/JBoss)] - Re: Modularising the appserver bootstrap

[adrian@jboss.org]

"kabir.khan at jboss.com" wrote : I see your point. Let's see what Adrian says, since it was he who originally asked me to move classpool and deployers into the AS codebase.
  | 
  | Reverting this would mean moving some classes back out of AS into AOP or duplicating them in AOP. Having a separate component effectively just means the same as that, with yet another dependency to manage. 
  | 
  | The classes in question are:
  | org.jboss.aop.asintegration.jboss5.AspectDeployer
  | org.jboss.aop.asintegration.jboss5.VFSClassLoaderDomainRegistry
  | org.jboss.aop.asintegration.jboss5.ScopedVFSClassLoaderDomain
  | org.jboss.aop.asintegration.jboss5.VFSClassLoaderScopingPolicy

So are these JBoss specific or not?

If this is appserver integration then it belongs in the appserver.

If this is some other integration, e.g. deployers-aop
then I wouldn't have a problem with them living at that level as a separate project.

As long as you are not creating a circular dependency (either really or in the
release process).

That doesn't mean the appserver has to use those specifc classes.

Ideally, these classes should be very thin anyway. i.e. the implementation
is in the aop project using agnostic policy metadata,
but the specific population of the policy choices is in the deployers.

I think you already fixed some of this already with the latest changes to
remove the deployment api dependency from the class pool.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4178309#4178309

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4178309