[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1454 Encapsulate Container infomation in TO/VO

[ALRubinger]

"jaikiran" wrote : I just noticed that there is a StatefulSessionInvokableContext (in proxy) which currently implements the InvokableContext. I guess, this should now implement the new InvokableSessionContext. Do you recommend that i change this too?

Yep. 

These look good to the naked eye, and I have all Unit Tests passing.  If you can verify the clusteredsession tests in TestSuite are OK, than this is good for commit.

There is one issue that we should probably break off from this work: "getDispatcherRegistrationName()" is being used throughout ProxyFactory code where perhaps "getName()" would be more appropriate.  

public ProxyFactoryBase(final String proxyFactoryName, InvokableContext container)
  |    {
  |       // Set properties
  |       this.setName(proxyFactoryName);
  |       this.setContainerName(container.getDispatcherRegistrationName());
  |       this.setContainerGuid(container.getGuid());
  |       this.setClassLoader(container.getClassloader());
  |       this.setAdvisor(container.getAdvisor());
  |    }
Part of my initial design of the proxy component was based on the assumption that'd we'd be referring to the Container by one name, and this is not necessarily the case (there's a name used to register it in MC/Ejb3Registrar, and another used to register w/ AOP Dispatcher, and these are not guaranteed to be equal).  So the solution there would involve adding something to ProxyFactory classes to support each property in the correct place.

Let's open up a JIRA to address that differentiation (and clear up the code so future maintainers don't get confused). 

S,
ALR

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4178512#4178512

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4178512