[jboss-dev-forums] [Design of Management Features on JBoss] - Re: Issues with MapCompositeValue

[ips]

Scott-

I think it would be better if MapCompositeValueSupport.put() did validity checking on the key and the value like CompositeValueSupport.set() does, rather than just updating the associated MapCompositeMetaType on the fly. Ideally, I'd also make MapCompositeMetaType immutable. This would prevent management clients from altering the MetaValues or the MetaTypes in invalid ways.

I think generifying these APIs a bit more would also make them more client-friendly. For example, why not generify the item MetaType in MapCompositeMetaType and MapCompositeValueSupport to <T extends MetaType> and generify the MetaValue in ManagedProperty to <V extends MetaValue>.

Fyi, I added some Javadoc to CompositeValue, MapCompositeValueSupport, and CompositeValueSupport. 


View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4226320#4226320

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4226320