[jboss-dev-forums] [Design of AOP on JBoss (Aspects/JBoss)] - Re: Help needed to create a patch.

[kabir.khan@jboss.com]

Hi Werner,

1)
I accepted your developer contract thing, but since we have had very few external committers to jboss aop and this process is new, I am unsure about how it works. I will make some enquiries, but the lead of jboss.org is on holiday.

2-5)
For testing we do two things
a) Make sure that the tests in aop/ itself do not fail with your changes, i.e.

  | cd aop/
  | ant -f build-tests-jdk50.xml tests
  | 

b) Make sure the test does not break the in AS tests
Check out jboss application server version 5.1.0.GA and build it

  | svn co https://svn.jboss.org/repos/jbossas/tags/JBoss_5_1_0_GA/
  | cd JBoss_5_1_0_GA/build
  | ./build.sh
  | cd output/jboss-5.1.0/bin
  | 

Update the aop version in the built AS.
Set up the pluggable-instrumentor.jar in the built bin/ directory and modify the run.sh to use it (if you need more detail here let me know)
Start the server:

  | ./run.sh -c all
  | 
  |   | 
  |   | In another console build and run the tests
  |   | 
  |   |   | cd JBoss_5_1_0_GA/testsuite
  |   |   | ./build.sh
  |   |   | ./build.sh test -Dtest=aop
  |   |   | ./build.sh smoke-tests-raw
  |   |   | 
  |   | 
  |   | Once that is done you can create a diff and upload it to JIRA and we'll take it from there :-)
  |   | 
  |   | Hope this helps
  |   | 

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4249348#4249348

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4249348