[jboss-dev-forums] [Design of Embedded JBoss] - Do we need Asset.getPath?

[ALRubinger]

Have had some debates with both Aslak and John on the subject.  From IRC today:

"#jboss-dev" wrote :  ALR: ping
  |  baileyje: Pong
  |  ALR: So I had thrown together a MemoryMap impl earlier before I realized Aslak had already put a partial one up.. Whoops
  |  baileyje: Hehe, whoever gets there first in working form wins.
  |  ALR: he ran into the same issue I did.  Asset does not have enough data to really support the Archive.add(Asset...) functionality.
  |  baileyje: Yep.
  |  ALR:  Is that encompassed in another task, or should there be an new task to update the API to support getting Path like info from an asset?
  |  baileyje: This is something we'd debated a lot.
  |  baileyje: I think I left it to aslak to determine if we need some getPath from Asset or not.  Hoping we wouldn't need it.
  |  ALR: Yeah.  Seems like you could get rid of it if required a Path of every addition
  |  baileyje: It may be demanded by TMPARCH-6
  |  baileyje: Right.
  |  I think my proposal was that every Asset addition needed a path
  |  And that "container " additions could know how to supply it.
  |  ALR:  That would keep Asset cleaner
  |  Like: addManifest("String") would assemble the default Path and Asset to add, then delegate to add(Path,Asset)
  |  baileyje: Yes, but I'm not sure if it works for every case.  I like the cleaner approach too.
  |  aslak disagreed on that poing.
  |  *point
  |  ALR:  Yeah..
  |  ALR: He wants the default path as a required attribute on each asset?
  |  baileyje: Yes.
  |  ALR:  hmmm..
  |  baileyje: I'll review your patches in a bit.  Trying to keep up with you guys while I'm pulled away to other things this week.
  |  ALR:  seems like we should require the path and leave asset clean and rely on the containers to establish the paths, until we have compelling evidence the Asset needs a path attr..
  |  baileyje: That's my position.
  |  baileyje: If you have the time to prove that to aslak, awesome.
  |  ALR:  K.  I will see if I can put something together.. It makes the MemoryMap much easier to impl a path required..
  |  And if in trying to prove it he was right all along, we eat our words.
  |  I'll mail him this little discussion
  |  for sure..
  |  Or better, post on the forum.

Aslak, now public for your review at your convenience.

Also I'd like to do more forum posts for topics that should leave some trail.  So we can all be in the conversation and remember the history.

S,
ALR

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4250485#4250485

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4250485