[jboss-dev-forums] [Design of POJO Server] - Re: Clustered DeploymentRepository for 5.1

[bstansberry@jboss.com]

"emuckenhuber" wrote : Hmm is the DeploymentManager enough for you then?

Not sure about the overall scope of this question, so I'll reply separately. ;)

anonymous wrote : 
  | just wondering what we should do with https://jira.jboss.org/jira/browse/JBAS-5682
  | 
  | IMO profile.addDeployment should not automatically deploy the deployment.
  | We could consider it on modifiedDeployments, but then you don't have any control about the lifecycle.
  | It will just get deployed when HDScanner runs the next time, which does not really makes sense to me.

Yes, re-reading the JBAS-5682 forum thread (http://www.jboss.org/index.html?module=bb&op=viewtopic&t=138120) I don't see why anything needs to be done. I agree that adding a deployment to the profile and telling the server to deploy it are distinct things and should be controlled by the client that calls the DeploymentManager, and not be made random by the HDScanner thread.  The 5.0.x HASingletonDeploymentScanner works fine that way, by calling DeploymentManager.distribute(name, phase, url, true) and then DeploymentManager.start().

In terms of the SPI, things are a bit confusing to me. Or perhaps I should say in terms of the implementation. Specifically, DeploymentManagerImpl.distribute(...). If you pass "true" as the copyContent param, on the server side DeployHandler.handleStream() gets called, which call DeploymentRepository.addDeploymentContent().  Simple enough.  The client then calls DeploymentManager.start() which calls DeployHandler.start() which passes the deployment to the MainDeployer.

It's more confused if you pass "false" to the copyContent param. In that case DeployHandler.distribute() gets called, which calls DeploymentRepository.addDeployment() and then passes the deployment to the MainDeployer.  A call to DeploymentManager.start() then seems redundant.

Passing a deployment to MainDeployer in two different places seems wrong.

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4210436#4210436

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4210436