[jboss-dev-forums] [Design of AOP on JBoss (Aspects/JBoss)] - JarJaring MC artifacts in jboss AS 4.2 installer script

[kabir.khan@jboss.com]

https://jira.jboss.org/jira/browse/JBAOP-693

The classes in the upgraded jboss-aop-jdk50.deployer/jboss-reflect.jar (MC 2) clash with the classes in JBoss AS 4.2.x's jboss-beans.deployer (MC 1), so we should use jarjar to rename its classes. There are no problems with the classes jboss-mdr.jar, but it probably won't hurt to do the same there. I have upgraded the release build to put jarjar.jar into jboss-aop-XXX/jboss-40-install/jboss-aop-jdk50.deployer so it is ready for use in the install build.xml.

I would still like to keep all the individual jars in jboss-aop-jdk50.deployer, so we should just use jarjar to rename the classes. I've never actually used jarjar, but I think that should be possible. Maybe the install script should rename jboss-reflect.jar and jboss-mdr.jar to something like jboss-reflect-aop-${aopversion}.jar and jboss-mdr-aop-${aopversion}.jar to make it clearer that they are not the "original jars"?

The top level packages in jboss-reflect.jar are:
org.jboss.beans
org.jboss.classadapter
org.jboss.config
org.jboss.joinpoint
org.jboss.reflect

The top-level packages in jboss-mdr.jar are:
org.jboss.annotation
org.jboss.metadata

The install script should run jarjar on all the jars in jboss-aop-jdk50.deployer to do the following replacements (http://code.google.com/p/jarjar/wiki/GettingStarted for the notation):
org.jboss.beans.++ -> org.jboss.beans. at 1
org.jboss.classadapter.++ -> org.jboss.jbossaop4deployermc2.classadapter. at 1
org.jboss.config.++ -> org.jboss.org.jboss.jbossaop4deployermc2.config. at 1
org.jboss.joinpoint.++ -> org.jboss.org.jboss.jbossaop4deployermc2.joinpoint. at 1
org.jboss.reflect.++ -> org.jboss.org.jboss.jbossaop4deployermc2.reflect. at 1
org.jboss.annotation.++ -> org.jboss.org.jboss.jbossaop4deployermc2.annotation. at 1
org.jboss.metadata.++ -> org.jboss.org.jboss.jbossaop4deployermc2.metadata. at 1



View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4202956#4202956

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4202956