[jboss-dev-forums] [Design the new POJO MicroContainer] - Re: MutableClassInfo?

[stale.pedersen@jboss.org]

"kabir.khan at jboss.com" wrote : 
  | "alesj" wrote : 
  |   | How does this effect the (weak type) cache? 
  |   | 
  | That is an implementation detail that needs to be reworked internally. Having Class as the key for this won't work since we don't want the class to be loaded. Internally the weak type cache stores class names in a map of cl, so this methods can work 
  | 
  |   | TypeInfoFactory.getTypeInfo(String name, ClassLoader cl)
  |   | 
  | The use of WeakClassCache by Javassist will need revisiting so that it does not try to load the class every time we try to look something up since that is not needed by the underlying implementation.
  | 
im looking into JavassistTypeInfoFactoryImpl and JavassistTypeInfo with the goal of getting them Mutable compliant (eg. no usage of Class). 

the last remaining problem i have with this is JavassistTypeInfo.getType(). with my changes this method will always return null, but this is breaking the testsuite since there are tests that depends on this returning the actual class.

from my point of view the getType() method do not have any meaning for a MutableClassInfo since the type isnt defined yet before the class has been frozen/loaded.

so either we can change the getType() method or we need to create a new implementation of JavassistTypInfo that is mutable compliant.

for reference, take a look at the diff here:http://github.com/stalep/jboss-reflect/commit/a1a396c2203d63ae487fc1dfc21806f35577fb7e

"kabir.khan at jboss.com" wrote : 
  | Create a wiki page with the work in progress?
atm im using git as a vcs, you can all take a look at it here:
http://github.com/stalep/jboss-reflect - note that i can push changes from the git repo back to jboss-reflect svn when wanted.

ill be posting design ideas/thoughts on a wiki too.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205591#4205591

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205591