[jboss-dev-forums] [Design of Embedded JBoss] - Re: External Contribution to AS Embedded

[ALRubinger]

"Josh Davis" wrote : I tried my hand at making the test for https://jira.jboss.org/jira/browse/JBBOOT-56
  | 
  | Check the patch attached to the issue and let me know if that's what you meant.

Great code in general.  I appreciated your commitment to documentation and cleanup/centralization as you go along.

In ripping jboss-bootstrap out of the Application Server, I've been especially sensitive to violation of scope and extending a component's concerns outside its domain.  In this case, startup/shutdown of bootstraps is provided by impl-base, and the attached patch addresses test cases in impl-mc.  This makes it more of a compliance/acceptance test where impl-mc validates it's getting a good impl-base.

So I've attached an alternate way of tackling the issue in "JBBOOT-56.v2.ALR.patch" on the JIRA.  Have a look and let me know what you think.

Some misc minor notes:

* You don't need AtomicInteger in LifecycleOrderPojo (as you hint); this is all single-threaded.
* We need to get you set up w/ JBoss licence headers and preferably with a formatter (if you're in Eclipse I have code templates).

I'm impressed that you've picked up the Bootstrap Server API and MC jboss-beans.xml deployments so quickly.  This was a good, working patch you've provided.  So let's just address the scope issue and move forward on something else? ;)

Outstanding questions:

* Do you have an account on jboss.org?  This enables posting to the forums, JIRA assignments, etc.
* Have you yet signed a contributor's agreement?  Once done I can commit on your behalf, and after a few patches, get you commit access.

http://jboss.org/contributor

S,
ALR

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4238639#4238639

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4238639