[jboss-dev-forums] [Design of JBoss ESB] - RemoteGatewayListener, RemoteFileSystemFactory, RemoteFileSy

[tfennelly]

This code is very interesting indeed :)

I was looking at it wrt JBESB-2524, specifically in relation to how it uses the ftpLocalDir and ftpRemoteDir config settings.

These settings are used by the FtpImpl and SecureFtpImpl classes, which are RemoteFileSystem implementations.  The are constructed from an EPR by the RemoteFileSystemFactory.  Both implementations initialise their ftpLocalDir and ftpRemoteDir config settings from the jboessesb-properties.xml.   It then loads this into a ConfigTree instance, calls checkParams, which goes and initializes the ftpLocalDir and ftpRemoteDir variables again from the configtree that was just constructed from the config.  Huh?

I hope somebody sees the logic in all of this toing and frowing with the config!!

Anyway... does anyone know what the real intention is here?  ftpLocalDir and ftpRemoteDir are currently being configured from the jbossesb-properties.xml.  Was there ever an intention to allow this to be overridden by the EPR ala how it is currently being set in the configtree passed by the RemoteGatewayListener to the ListenerUtil.assembleEpr method?  

As I see it, this code in RemoteGatewayListener is currently doing nothing.  Can we just remove it and skip the EPR override that we don't have?

Also on this FTP code... looks to me like RemoteFileSystem instances are potentially being created for fun by (e.g.) the RemoteFileMessageComposer i.e. for every message.  Is this really necessary, or can we just create one for the RemoteFileMessageComposer instance?

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4240422#4240422

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4240422