[jboss-dev-forums] [Design of JBoss ESB] - Re: RemoteGatewayListener, RemoteFileSystemFactory, RemoteFi

[tfennelly]

"Kevin.Conner at jboss.com" wrote : "tfennelly" wrote : These settings are used by the FtpImpl and SecureFtpImpl classes, which are RemoteFileSystem implementations.  The are constructed from an EPR by the RemoteFileSystemFactory.  Both implementations initialise their ftpLocalDir and ftpRemoteDir config settings from the jboessesb-properties.xml.
  | I'll be very surprised if this is the case, are you certain of this?  How could any of the ftp/sftp stuff work in that case.  As already mentioned on the JIRA issue, it looks like the local dir is not getting passed through but the remote must be getting through otherwise it just wouldn't work.

FtpImpl and SecureFtpImpl are constructed from an EPR, but the ftpLocalDir and ftpRemoteDir settings are not coming from the EPR.  They are being read from the jbossesb-properties.xml.  Then... they construct a ConfigTree instance from the data read from the EPR + the data read from the jbossesb-properties.xml.  The the configTree is used to initialize everything again and this is what I mean by toing and frowing :)

So, the code that I think is irrelevant (and should be removed) is the code in the RemoteGatewayListener class (71 to 77).  It's setting ftpLocalDir and ftpRemoteDir on a ConfigTree instance (not the same instance I talk about above) and constructing an EPR from the ConfigTree.  Bu the EPR doesn't support ftpLocalDir and ftpRemoteDir.  

I was also thinking that setting these on the EPR was a bit strange and that it should be defined at the system level.  I didn't say it in the last post, but since you seem to think the same thing then that's cool :)

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4240658#4240658

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4240658