[jboss-dev-forums] [Design of EJB 3.0] - Re: EJBTHREE-1800 Current status on performance improvement

[jaikiran]

"jaikiran" wrote : 
  | 
  | 1) ... (/reinitialization)
  | 
  | 

During EJB3Deployment processing, we have this piece of code:


  | List<Container> containers = handler.getContainers(cf, this);
  | for (Container con : containers)
  | {
  |   // EJBContainer has finished with all metadata initialization from XML files and such.
  |   // this is really a hook to do some processing after XML has been set up and before
  |   // and processing of dependencies and such.
  |   try
  |   {
  |       ((EJBContainer) con).instantiated();
  | 
  | 

handler.getContainers returns the correct container and also internally initializes all the AOP related stuff for the BeanContainer. After all this initialization is done, the next line we do this:


  |       ((EJBContainer) con).instantiated();
  | 

which internally does:


  | public void instantiated()
  |    {
  |       this.businessInterfaces = resolveBusinessInterfaces();
  |       
  |       // Before we start to process annotations, make sure we also have the ones from interceptors-aop.
  |       // FIXME: because of the flaked life cycle of an EJBContainer (we add annotations after it's been
  |       // constructed), we must reinitialize the whole thing. 
  |       beanContainer.reinitializeAdvisor();
  | 
  |    }
  | 

Does the comments still hold good? Because, i don't see anything in the code (between those 2 lines) which neccessitates the reinitialization. The re-initializing causes all of the (time consuming) AOP stuff to be done again. Am i missing something?

Can we remove the reinitialization part? (I am going to start a testsuite run with this change to see if it affects any functionality, but wanted to have other inputs).



View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4228895#4228895

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4228895