[jboss-dev-forums] [Design of Management Features on JBoss] - Re: How to Expose MBean Invocation Stats into admin-console?

[ALRubinger]

The logic is odd to me:

* Loop through all outputs from all deployers
* If that output has a corresponding attachment, make a managed object out of it.

Why not just:

[alrubinger at localhost 2.0.7.GA]$ svn di deployers-spi/src/main/java/org/jboss/deployers/spi/deployer/helpers/DefaultManagedObjectCreator.java
  | Index: deployers-spi/src/main/java/org/jboss/deployers/spi/deployer/helpers/DefaultManagedObjectCreator.java
  | ===================================================================
  | --- deployers-spi/src/main/java/org/jboss/deployers/spi/deployer/helpers/DefaultManagedObjectCreator.java	(revision 89514)
  | +++ deployers-spi/src/main/java/org/jboss/deployers/spi/deployer/helpers/DefaultManagedObjectCreator.java	(working copy)
  | @@ -21,6 +21,7 @@
  |   */
  |  package org.jboss.deployers.spi.deployer.helpers;
  |  
  | +import java.util.Collection;
  |  import java.util.Map;
  |  import java.util.Set;
  |  
  | @@ -73,12 +74,14 @@
  |        if(factory == null )
  |           factory = ManagedObjectFactoryBuilder.create();
  |  
  | -      for(String name : attachments)
  | +      final Map<String,Object> duAttachments = unit.getAttachments();
  | +      final Collection<String> attachmentNames = duAttachments.keySet();
  | +      for(final String attachmentName:attachmentNames)
  |        {
  | -         Object instance = unit.getAttachment(name);
  | +         Object instance = unit.getAttachment(attachmentName);
  |           if (instance != null)
  |           {
  | -            ManagedObject mo = factory.initManagedObject(instance, null, metaData, name, null);
  | +            ManagedObject mo = factory.initManagedObject(instance, null, metaData, attachmentName, null);
  |              if (mo != null)
  |                 managedObjects.put(mo.getName(), mo);
  |           }

S,
ALR

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4234138#4234138

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4234138