[jboss-dev-forums] [JCA Development] - Re: Implementation of the ConnectionManager Service

[jesper.pedersen]

Hi Gurkan.

Overall the patch looks good, thanks :)

A couple of points though:

1) Make sure that the patch compiles with JDK5 (couple of classes)

2) Check the output from

  | ant checkstyle
  | 
One class.

3) Check the output from

  | ant findbugs
  | 
There are some warnings that needs to fixed, or added to the findbugs filter.

Other than that we will look into the package structure later on if we need to change it.

It would be great if you could submit a separate patch with JUnit test cases - I would like to have the

  | ant cobertura
  | 
task report as high numbers as possible.

Thanks again for your contributions !

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4252867#4252867

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4252867