[jboss-dev] Weird trace log

[David M. Lloyd]

On Thu, 16 Aug 2007 17:22:38 +0200
Adrian <abrock at redhat.com> wrote:

> On Thu, 2007-08-16 at 09:12 -0500, David M. Lloyd wrote:
> > On Thu, 16 Aug 2007 14:51:44 +0200
> > Adrian <abrock at redhat.com> wrote:
> > 
> > > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/structure/StructureDeployerWrapper.java?revision=63687&view=markup
> > 
> > > 41 :  private Logger log;
> > 
> > Bleah - loggers really ought to be static.  Creating a zillion loggers caused
> > significant performance problems in vfs one time already.
> > 
> 
> There are only 5 structure deployers and each is a singleton.

OK.  In this case though maybe a comment is in order:

"I solemnly swear that using an instance field for the Logger will
not cause a massive explosion of logger instances, because there will
only ever be five instances of this class."

:-)

- DML