Not binding to localhost by default in jboss-head was: Re: [jboss-dev] Clustering bootstrap still taking a long time
Dimitris Andreadis
dandread at redhat.com
Thu Nov 8 11:36:44 EST 2007
Adrian wrote:
> I've fixed this in head.
> http://jira.jboss.com/jira/browse/JBAS-4954
>
> But I think the code in jboss-4.2 for the defaults for other
> bind address is wrong.
>
> It currently says:
>
>
> // JBAS-4119, set the java.rmi.server.hostname if not set
> if (System.getProperty("java.rmi.server.hostname") == null)
> {
> System.setProperty("java.rmi.server.hostname", "127.0.0.1");
> }
>
> This has two problems:
> 1) It doesn't set the other bind addresses
> 2) It doesn't necessarily agree with what the real bind address is.
>
> In fact, it doesn't resolve the problem I'm seeing because
> it doesn't set the jgroups.bind.addr property.
>
> In jboss-head I've made the code:
>
> // Fix up other bind addresses
> String bindAddress =
> System.getProperty(ServerConfig.SERVER_BIND_ADDRESS);
> if (System.getProperty("java.rmi.server.hostname") == null)
> System.setProperty("java.rmi.server.hostname", bindAddress);
> if (System.getProperty("bind.address") == null)
> System.setProperty("bind.address", bindAddress);
> if (System.getProperty("jgroups.bind_addr") == null)
> System.setProperty("jgroups.bind_addr", bindAddress);
>
> Dimitris, is there a reason why you didn't fixup all
> the bind addresses (see the -b handling code) in 4.2?
I don't remember changing the bind address myself in trunk? That was a TODO item :-)
They should be similar, yes.
More information about the jboss-development
mailing list