[jboss-dev] jboss-aspects

[Anil Saldhana]

Those helpers manage security stuff for both ejb2 and ejb3. I do not 
want to move them into the security (JBossSX) project, since I do not 
want to introduce a dependency on an implementation class from JBossSX.

So I will duplicate the code from AS/security/xxxHelpers in the proposed 
ejb3/security just for ejb3. Once I do that the helpers are useless 
because ejb2 is the only one using them.

I seriously do not think the so called ejb3 core is not really ejb3 
core. What is a class like EJBContextImpl doing in ejb3 core? It should 
be in AS/ejb3. The ejb3 core should be further slimmed down.

Dimitris Andreadis wrote:
> So you've moved the interceptor from jboss-aspects to ejb3/core?
> 
> - Is this what we want, i.e. do not have a security aspects project?
> 
> - If moved inside ejb3, Carlo says it should be in a separate 
> ejb3/security module (correct me if wrong)
> 
> - ejb3/core still depends on org.jboss.jbossas:jboss-as-security
> 
> I see it imports:
> org.jboss.security.integration.ejb.EJBAuthorizationHelper
> org.jboss.security.integration.ejb.EJBAuthenticationHelper
> 
> from
> ./org/jboss/ejb3/EJBContextImpl.java
> ./org/jboss/ejb3/security/Ejb3AuthenticationInterceptorv2.java
> ./org/jboss/ejb3/security/RoleBasedAuthorizationInterceptorv2.java
> 
> Anil Saldhana wrote:
>> Dimitris,
>>   EJB3 should not be relying now on anything from aspects/security. I 
>> moved the SecurityClientInterceptor into the ejb3 security layer.
>>
>> I do not do "embedded". So not sure if it uses aspects/security. 
>> Probably it does.
>>
>> Regards,
>> Anil
>>
>> Dimitris Andreadis wrote:
>>> JIRA project for aspects:
>>> http://jira.jboss.com/jira/browse/JBASPECT
>>>
>>> Dimitris Andreadis wrote:
>>>> http://jira.jboss.com/jira/browse/JBAS-5390
>>>>
>>>> The new jboss-aspects module is started here:
>>>> https://svn.jboss.org/repos/jbossas/projects/jboss-aspects/
>>>>
>>>> We need to start creating sub-modules for the various aspects (tx, 
>>>> asynch, remoting, security, clustering)