[jboss-dev] Patch for JBAS-5471

[Galder Zamarreno]

I've been thinking through this a bit further, so please bear with me :)

To be mote precise, my test case is just a simple EJB3 service I'm 
trying to deploy. Right now, this is just an example I have and haven't 
integrated into any testsuite or anything.

(Side note: I'm doing all this cos I was trying to verify whether 
http://jira.jboss.com/jira/browse/EJBTHREE-1015 fails in trunk as well.)

So, unless EJB3 team are planning to move such tests into AS testsuite 
(They have AS deployment tests in EJB3 project), I have the feeling it 
might be pointless for me to add another deployment, in-AS, test to 
org.jboss.test.ejb3.service in jbossas/testsuite. Am I right? Judging 
from the link you passed me, they already have such type of tests there.

What probably makes more sense is for org.jboss.test.ejb3.service 
package (or if diving by lines of function, which I'm happy with, 
org.jboss.test.deployers.ejb3, bearing in mind that I'm trying to test 
code in org.jboss.ejb3.deployers.*) within jbossas/testsuite to contain 
standalone unit test that mocks other parts and tests the integration 
code itself.

I can see adding more value with the latter rather than repeating a EJB3 
service deployment test within jbossas/testsuite and I'm more than happy 
to do such thing.

Does this make any sense? Carlo?

Scott Stark wrote:
> There is no specific org.jboss.test.ejb3 package as the tests are 
> packaged more along the lines of the function. Create an 
> org.jboss.test.ejb3.service package under the testsuite module and add 
> your testcase.
> 
> The code in question is part of the jbossas/ejb3 deployers integration 
> code.
> 
> Galder Zamarreno wrote:
>>
>>
>> Scott Stark wrote:
>>> Integration specific tests are in jbossas/testsuite. The ejb3-core 
>>> tests still have a lot of integration tests:
>>>
>>> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>>
>> In this particular case, assuming that the code I wanna be fixing 
>> lives  in AS within the ejb3 integration layer, any test case I create 
>> for this should live in AS, correct?
>>
>> I don't see any org.jboss.test.ejb3 package to test the ejb3 
>> integration layer in jbossas/testsuite unless these tests are located 
>> somewhere else.
>>
>> Or do you expect a test case to fix JBAS-5471, assuming the fix only 
>> involved fixing the ejb3 integration layer in AS, to live in the ejb3 
>> project? I'm sure there's such test there but probably those tests 
>> haven't run yet as the EJB3 team are currently trying to untangle the 
>> dependency issues.
> 

-- 
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat