[jboss-dev] JBoss AS 6.0.0.Final Tagged today at 20:00 UTC

[Shelly McGowan]

30 minutes, 0 regressions 



Shelly McGowan
JBoss, by Red Hat

----- Original Message -----
From: "Remy Maucherat" <remy.maucherat at gmail.com>
To: "JBoss.org development list" <jboss-development at lists.jboss.org>
Sent: Thursday, December 23, 2010 2:09:47 PM
Subject: Re: [jboss-dev] JBoss AS 6.0.0.Final Tagged today at 20:00 UTC

On Thu, Dec 23, 2010 at 7:54 PM, Shelly McGowan <smcgowan at redhat.com> wrote:
> Remy,
>
> The JIRA mentions there is a workaround.  Or, are you considering
> a fix prior to the tag?

The workaround is to avoid referencing non existing fragments. I
thought this was an error, but it's not (and the TCK does not test
it). Maybe they can use "after others" instead.

The fix should be to remove the exception, and things should be fine.

### Eclipse Workspace Patch 1.0
#P jbossas-6
Index: server/src/main/java/org/jboss/web/deployers/MergedJBossWebMetaDataDeployer.java
===================================================================
--- server/src/main/java/org/jboss/web/deployers/MergedJBossWebMetaDataDeployer.java	(revision
109752)
+++ server/src/main/java/org/jboss/web/deployers/MergedJBossWebMetaDataDeployer.java	(working
copy)
@@ -21,7 +21,6 @@
  */
 package org.jboss.web.deployers;

-import java.io.IOException;
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -277,18 +276,14 @@
             }
             else
             {
-               boolean found = false;
                for (WebOrdering ordering : orderings)
                {
                   if
(orderingElementMetaData.getName().equals(ordering.getName())) {
                      order.add(ordering.getJar());
                      jarsSet.remove(ordering.getJar());
-                     found = true;
                      break;
                   }
                }
-               if (!found)
-                  throw new DeploymentException("Could not resolve
name in absolute ordering: " + orderingElementMetaData.getName());
             }
             i++;
          }
@@ -705,11 +700,6 @@
                       found = true;
                   }
               }
-              if (!found) {
-                  // Unknown name
-                  //throw new
IllegalStateException(sm.getString("ordering.unkonwnName",
webOrdering.getJar()));
-                 throw new IllegalStateException("Unknown name
declared in JAR: " + webOrdering.getJar());
-              }
           }
           Iterator<String> before = webOrdering.getBefore().iterator();
           while (before.hasNext()) {
@@ -729,11 +719,6 @@
                       found = true;
                   }
               }
-              if (!found) {
-                  // Unknown name
-                  //throw new
IllegalStateException(sm.getString("ordering.unkonwnName",
webOrdering.getJar()));
-                 throw new IllegalStateException("Unknown name
declared in JAR: " + webOrdering.getJar());
-              }
           }
       }

Rémy

_______________________________________________
jboss-development mailing list
jboss-development at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development