[jboss-jira] [JBoss JIRA] Commented: (JBAS-3482) Still a WARN message during failed close

[Adrian Brock (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-3482?page=comments#action_12340732 ] 
            
Adrian Brock commented on JBAS-3482:
------------------------------------

Also, there is little point BaseWrapperManagedConnection.destroy() invoking checkException().

If connection.close() throws an exception, checking the error message and rethrowing it serves 
no purpose.

Just logging the error at debug level should be enough.

> Still a WARN message during failed close
> ----------------------------------------
>
>                 Key: JBAS-3482
>                 URL: http://jira.jboss.com/jira/browse/JBAS-3482
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: JCA service
>    Affects Versions: JBossAS-4.0.4.GA
>            Reporter: Adrian Brock
>         Assigned To: Weston Price
>             Fix For: JBossAS-4.0.5.GA
>
>
> Further to JBAS-1831, there is a still a WARN message in the path
> when it fails to close a connection. It is in the InternalManagedConnectionPool
>    /**
>     * Destroy a connection
>     *
>     * @param cl the connection to destroy
>     */
>    private void doDestroy(ConnectionListener cl)
>    {
>       if (cl.getState() == ConnectionListener.DESTROYED)
>       {
>          log.trace("ManagedConnection is already destroyed " + cl);
>          return;
>       }
>       connectionCounter.dec();
>       cl.setState(ConnectionListener.DESTROYED);
>       try
>       {
>          cl.getManagedConnection().destroy();
>       }
>       catch (Throwable t)
>       {
>          log.warn("Exception destroying ManagedConnection " + cl, t); // <----------- This should be a debug message
>       }
>    }
> It can be seen in the following stacktrace:
> org.jboss.resource.JBossResourceException: SQLException; - nested throwable: (java.sql.SQLException: Io exception: Broken pipe)
>         at org.jboss.resource.adapter.jdbc.BaseWrapperManagedConnection.checkException(BaseWrapperManagedConnection.java:481)
>         at org.jboss.resource.adapter.jdbc.BaseWrapperManagedConnection.destroy(BaseWrapperManagedConnection.java:206)
>         at org.jboss.resource.connectionmanager.InternalManagedConnectionPool.doDestroy(InternalManagedConnectionPool.java:550)
>         at org.jboss.resource.connectionmanager.InternalManagedConnectionPool.removeTimedOut(InternalManagedConnectionPool.java:415)
>         at org.jboss.resource.connectionmanager.IdleRemover$1.run(IdleRemover.java:81)
>         at java.lang.Thread.run(Thread.java:595)
> Caused by: java.sql.SQLException: Io exception: Broken pipe
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:255)
>         at oracle.jdbc.driver.T4CConnection.logoff(T4CConnection.java:480)
>         at oracle.jdbc.driver.PhysicalConnection.close(PhysicalConnection.java:1175)
>         at org.jboss.resource.adapter.jdbc.BaseWrapperManagedConnection.destroy(BaseWrapperManagedConnection.java:202)
>         ... 4 more

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira