[jboss-jira] [JBoss JIRA] Closed: (JBWEB-67) Patch to fix usabillity issues with the rewrite valve

[Remy Maucherat (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBWEB-67?page=all ]

Remy Maucherat closed JBWEB-67.
-------------------------------

    Resolution: Done

Please do not reopen the report. All the examples (including the one you just gave), and all the documentation, does complete matches of the TestString. In all the example which may look like some partial match is made, there's usage of a RewriteBase directive, which is not supported here, and may give this impression. This is a very important difference.

> Patch to fix usabillity issues with the rewrite valve
> -----------------------------------------------------
>
>                 Key: JBWEB-67
>                 URL: http://jira.jboss.com/jira/browse/JBWEB-67
>             Project: JBoss Web
>          Issue Type: Patch
>      Security Level: Public(Everyone can see) 
>          Components: Rewrite Valve
>    Affects Versions: JBoss Web Server 1.0.0 GA
>            Reporter: Rob Hughes
>         Assigned To: Remy Maucherat
>             Fix For: JBoss Web Server 1.0.0 GA
>
>         Attachments: rewrite_valve.patch
>
>
> I'm providing this patch which fixes the following issues with the rewrite valve and makes it's behavior more consistent with mod_rewrite.
> 1: Rewrite conditions were not being processed
> 2: Case insensitive pattern matches were not working
> 3: Send redirect with an arbitrary code now works and uses reflection to see if the method is available so the valve will still work with standalone tomcat
> 4: Patterns are no longer forced to match the whole input for conditions and rules
> 5: The server variable HTTP_HOST included the port if the server wasn't running on the standard ones (80/443)
> 6: QSA is how handled and query strings are appended where appropriate
> 7: Comments are now allowed in the rewrite.properties file
> The patch is against the jbossweb trunk.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira