[jboss-jira] [JBoss JIRA] Commented: (JBAS-3546) Change log level on CachedConnectionManager.closeConnection() to warn

[Felipe Leme (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-3546?page=comments#action_12341632 ] 
            
Felipe Leme commented on JBAS-3546:
-----------------------------------

Hmm, is it possible? I didn't know....

Anyway, even if that's possible, I think it is not trivial and can be confusing for the unaware user. I mean, suppose you configure log4.xml to receive all warn and errors without knowing about CachedConnectionManager; eventually, you may reach the situation where it dumps a stracktrace in the log (as an info() call) and such stacktrace is not sent by email...

Maybe an intermediate alternative would be adding such entry in the log4j.xml SMTP appender (which is already commented out by default).

> Change log level on CachedConnectionManager.closeConnection() to warn
> ---------------------------------------------------------------------
>
>                 Key: JBAS-3546
>                 URL: http://jira.jboss.com/jira/browse/JBAS-3546
>             Project: JBoss Application Server
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: JCA service
>    Affects Versions: JBossAS-4.0.4.GA
>            Reporter: Felipe Leme
>         Assigned To: Weston Price
>            Priority: Trivial
>   Original Estimate: 5 minutes
>  Remaining Estimate: 5 minutes
>
> The feature of the CachedConnectionManager automatically closing connections (and warning about the fact) is pretty useful; in fact, so useful that we would like to receive email notifications when it occurs. But, unfortunatelly, we are not receiving such notifications, as our log4j SMTP appender is set to the WARN threshold, while such warnings are being logged as info:
>             if (e != null)
>                log.info("Closing a connection for you.  Please close them yourself: " + c, e);
>             else
>                log.info("Closing a connection for you.  Please close them yourself: " + c);
>             m.invoke(c, new Object[]{});
>          }
>          catch (Throwable t)
>          {
>             log.info("Throwable trying to close a connection for you, please close it yourself", t);
>          }
>       }
>       catch (NoSuchMethodException nsme)
>       {
>          log.info("Could not find a close method on alleged connection objects.  Please close your own connections.");
>       }
> So, I'm proposing these loggings are changed from info() to warn() - I don't think such change will cause any 'logging havoc', as the messages are only logged when the CachedConnectionManager is set to debug them...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira