[jboss-jira] [JBoss JIRA] Resolved: (JBRULES-455) java.lang.NullPointerException at org.drools.util.LinkedList.remove(Unknown Source) in 3.0.4 while not in 3.0.3

[Edson Tirelli (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBRULES-455?page=all ]

Edson Tirelli resolved JBRULES-455.
-----------------------------------

    Fix Version/s: 3.0.5
       Resolution: Done

Problem was that join node modifyTuple() method was keeping a reference to an invalidated fact handle, and later, trying to remove it again from a list, causing a NPE.

Problem fixed and commited

3.0.x branch: revision #5997
--------------------
Adding         drools-compiler/src/test/java/org/drools/Approach.java
Adding         drools-compiler/src/test/java/org/drools/Close.java
Adding         drools-compiler/src/test/java/org/drools/Target.java
Sending        drools-compiler/src/test/java/org/drools/integrationtests/IntegrationCases.java
Adding         drools-compiler/src/test/resources/org/drools/integrationtests/test_JoinNodeModifyTuple.drl
Sending        drools-core/src/main/java/org/drools/reteoo/JoinNode.java
Sending        drools-core/src/main/java/org/drools/reteoo/beta/DefaultRightMemory.java
Transmitting file data .......
Committed revision 5997.
--------------------

trunk: revision #5998
--------------------
Adding         drools-compiler/src/test/java/org/drools/Approach.java
Adding         drools-compiler/src/test/java/org/drools/Close.java
Adding         drools-compiler/src/test/java/org/drools/Target.java
Sending        drools-compiler/src/test/java/org/drools/integrationtests/IntegrationCases.java
Adding         drools-compiler/src/test/resources/org/drools/integrationtests/test_JoinNodeModifyTuple.drl
Sending        drools-core/src/main/java/org/drools/reteoo/JoinNode.java
Sending        drools-core/src/main/java/org/drools/reteoo/beta/DefaultRightMemory.java
Transmitting file data ...
Committed revision 5998.
---------------------

Ruslan, thank you for providing a good report and test case. 
Please, test and let me know if you have any other problem. Fix will be included in version 3.0.5 or you can get source files directly from subversion repository.

Regards,
Edson

> java.lang.NullPointerException at org.drools.util.LinkedList.remove(Unknown Source) in 3.0.4 while not in 3.0.3
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: JBRULES-455
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-455
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Reteoo
>    Affects Versions: 3.0.4
>         Environment: WindowsXP, eclipse3.2
>            Reporter: Ruslan Sorokin
>         Assigned To: Edson Tirelli
>             Fix For: 3.0.5
>
>         Attachments: JBossRulesTest.zip
>
>
> java.lang.NullPointerException
> 	at org.drools.util.LinkedList.remove(Unknown Source)
> 	at org.drools.reteoo.ObjectMatches.remove(Unknown Source)
> 	at org.drools.reteoo.JoinNode.modifyTuple(Unknown Source)
> 	at org.drools.reteoo.LeftInputAdapterNode.modifyObject(Unknown Source)
> 	at org.drools.reteoo.ObjectSource.propagateModifyObject(Unknown Source)
> 	at org.drools.reteoo.ObjectTypeNode.modifyObject(Unknown Source)
> 	at org.drools.reteoo.Rete.modifyObject(Unknown Source)
> 	at org.drools.reteoo.ReteooRuleBase.modifyObject(Unknown Source)
> 	at org.drools.reteoo.ReteooWorkingMemory.modifyObject(Unknown Source)
> 	at org.drools.base.DefaultKnowledgeHelper.modifyObject(Unknown Source)
> 	at TrafficControl.Rule_Approach_Continue_0.consequence(Rule_Approach_Continue_0.java:16)
> 	at TrafficControl.Rule_Approach_Continue_0ConsequenceInvoker.evaluate(Rule_Approach_Continue_0ConsequenceInvoker.java:36)
> 	at org.drools.common.DefaultAgenda.fireActivation(Unknown Source)
> 	at org.drools.common.DefaultAgenda.fireNextItem(Unknown Source)
> 	at org.drools.common.AbstractWorkingMemory.fireAllRules(Unknown Source)
> 	at org.drools.common.AbstractWorkingMemory.fireAllRules(Unknown Source)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira