[jboss-jira] [JBoss JIRA] Created: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs

Clebert Suconic (JIRA) jira-events at jboss.com
Sat Dec 9 14:54:38 EST 2006


Client.disconnect without clearing ConnectionListeners will cause NPEs
----------------------------------------------------------------------

                 Key: JBREM-648
                 URL: http://jira.jboss.com/jira/browse/JBREM-648
             Project: JBoss Remoting
          Issue Type: Bug
      Security Level: Public (Everyone can see)
            Reporter: Clebert Suconic
         Assigned To: Tom  Elrod


ConnectionValidator should be stoped when disconnected is called.


ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:

   public void run()
   {
      try
      {
         boolean isValid = checkConnection(client.getInvoker().getLocator(), client.getConfiguration());



The fix should be simple though:

   public void disconnect()
   {
      if (invoker != null)
      {
         if(enableLease)
         {
            invoker.terminateLease(sessionId);
            enableLease = false;
         }

         if (validator!=null) // /this is the fix.....
         {
              validator.stop();
         }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list