[jboss-jira] [JBoss JIRA] Commented: (JBCACHE-910) TreeCache.createSubtreeRootNode(Fqn subtree) ugliness

[Brian Stansberry (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBCACHE-910?page=comments#action_12349172 ] 
            
Brian Stansberry commented on JBCACHE-910:
------------------------------------------

Yeah, this stuff was added before it was possible to do a simple put() w/ an empty data map and a local-only option.  I suspect that's the way to go, but we need to think through the whole interceptor chain to make sure no interceptor is going to do something unwanted.

The lock_table thing is just wacked.  I suspect a refactor gone awry.

> TreeCache.createSubtreeRootNode(Fqn subtree) ugliness
> -----------------------------------------------------
>
>                 Key: JBCACHE-910
>                 URL: http://jira.jboss.com/jira/browse/JBCACHE-910
>             Project: JBoss Cache
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Elias Ross
>         Assigned To: Manik Surtani
>
> This method is called by the region manager.
> There's a bunch of Voodoo taking place here, legacy bits mixed with some newer stuff.
> One thing that strikes me as wrong already is this code:
> child = factory.createDataNode(type, name,
>                        subtree.getFqnChild(i + 1),
>                        parent, lock_table, coordinator, null, this.rootSpi);
> For some reason, it is passing the lock_table into the Node as the data to initialize the node with.
> Somehow I think the right way to fix this would be to do a Cache.addChild(Fqn) call in RegionManager and remove this method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira