[jboss-jira] [JBoss JIRA] Commented: (JBPM-675) Able to kill and suspend a process or token that has ended

[Chris OBrien (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBPM-675?page=comments#action_12339829 ] 
            
Chris OBrien commented on JBPM-675:
-----------------------------------

In TaskInstance.java, i replaced the resume() method with:

  public void resume() {
    if( end == null ) {
        // Only re-open the task if the task was not previously completed
        isOpen = true;
    }   
    isSuspended = false;        
  }


The isSuspended=false; could be moved up inside the if..block, but since the suspend() method is still marking ended tasks as suspended, I figured might as well unsuspend them.  Question goes back to this original bug.  Do we want to error on suspending a closed taskinstance?  Or just send a warning to the log  and do nothing when a closed task is suspended?

> Able to kill and suspend a process or token that has ended
> ----------------------------------------------------------
>
>                 Key: JBPM-675
>                 URL: http://jira.jboss.com/jira/browse/JBPM-675
>             Project: JBoss jBPM
>          Issue Type: Patch
>          Components: Core Engine
>    Affects Versions: jBPM 3.1.1
>         Environment: Mac OS X 10.4.6 Java 1.4.2_09
>            Reporter: michaelklem
>         Assigned To: Tom Baeyens
>            Priority: Trivial
>
> When a process instance or token has ended, I can still call the suspend, resume and kill APIs on that process instance or token without an exception being thrown. IMO an exception should be thrown to indicate that these APIs are used in an illegal state.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira