[jboss-jira] [JBoss JIRA] Updated: (JBAS-3813) BaseWrapperManagedConnectionFactory.isStaleConnection creates new class instance every call

[Elias Ross (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBAS-3813?page=all ]

Elias Ross updated JBAS-3813:
-----------------------------

        Summary: BaseWrapperManagedConnectionFactory.isStaleConnection creates new class instance every call  (was: BaseWrapperManagedConnectionFactory.isStaleConnection creates new class every call)
    Description: 

   boolean isStaleConnection(SQLException e)
   {
      boolean isStale = false;
      
      if(staleConnectionChecker != null)
      {
      
         isStale = staleConnectionChecker.isStaleConnection(e); 
         
      }
      
      if(staleConnectionCheckerClassName != null)
      {
         

should change to:

   boolean isStaleConnection(SQLException e)
   {
      
      if(staleConnectionChecker != null)
      {
      
         return staleConnectionChecker.isStaleConnection(e); 
         
      }
      
      if(staleConnectionCheckerClassName != null)
      {
         


  was:
}

   boolean isStaleConnection(SQLException e)
   {
      boolean isStale = false;
      
      if(staleConnectionChecker != null)
      {
      
         isStale = staleConnectionChecker.isStaleConnection(e); 
         
      }
      
      if(staleConnectionCheckerClassName != null)
      {
         

should change to:



> BaseWrapperManagedConnectionFactory.isStaleConnection creates new class instance every call
> -------------------------------------------------------------------------------------------
>
>                 Key: JBAS-3813
>                 URL: http://jira.jboss.com/jira/browse/JBAS-3813
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: JBossAS-5.0.0.Beta
>            Reporter: Elias Ross
>            Priority: Minor
>
>    boolean isStaleConnection(SQLException e)
>    {
>       boolean isStale = false;
>       
>       if(staleConnectionChecker != null)
>       {
>       
>          isStale = staleConnectionChecker.isStaleConnection(e); 
>          
>       }
>       
>       if(staleConnectionCheckerClassName != null)
>       {
>          
> should change to:
>    boolean isStaleConnection(SQLException e)
>    {
>       
>       if(staleConnectionChecker != null)
>       {
>       
>          return staleConnectionChecker.isStaleConnection(e); 
>          
>       }
>       
>       if(staleConnectionCheckerClassName != null)
>       {
>          

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira