[jboss-jira] [JBoss JIRA] Resolved: (JBRULES-481) LeftInputAdater.updateNewNode does incorrect propagation

[Edson Tirelli (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBRULES-481?page=all ]

Edson Tirelli resolved JBRULES-481.
-----------------------------------

    Resolution: Done

Issue fixed on 3.0.x branch in revision #7436:

$ svn commit -m "JBRULES-481: fixing add/removal issue on LIAN and sharing counter on TerminalNode" drools-core/src/
Sending        drools-core/src/main/java/org/drools/reteoo/LeftInputAdapterNode.java
Sending        drools-core/src/main/java/org/drools/reteoo/TerminalNode.java
Transmitting file data ..
Committed revision 7436.

Issue does not exist in trunk due to completelly new refactored code.


> LeftInputAdater.updateNewNode does incorrect propagation
> --------------------------------------------------------
>
>                 Key: JBRULES-481
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-481
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Reteoo
>    Affects Versions: 3.0.4
>            Reporter: Mark Proctor
>         Assigned To: Edson Tirelli
>             Fix For: 3.0.5, 3.1-m1
>
>
>         // Get the newly attached TupleSink
>         final TupleSink sink = (TupleSink) getTupleSinks().get( getTupleSinks().size() - 1 );
>         // Iterate the memory and assert all tuples into the newly attached TupleSink
>         final Map memory = (Map) workingMemory.getNodeMemory( this );
>         for ( final Iterator it = memory.values().iterator(); it.hasNext(); ) {
>             final LinkedList list = (LinkedList) it.next();
>             for ( LinkedListNode node = list.getFirst(); node != null; node = node.getNext() ) {
>                 sink.assertTuple( (ReteTuple) ((LinkedListObjectWrapper) node).getObject(),
>                                   context,
>                                   workingMemory );
>             }
>         }
> We get the last Sink but then we send through ALL tuples in the list to that single sink. yet we know that each tuple is for a specific sink. we instead should grab the handle and create a new tuple which we add to the list.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira