[jboss-jira] [JBoss JIRA] Created: (JBRULES-544) getQueryResults behavior: return null

Edson Tirelli (JIRA) jira-events at jboss.com
Tue Nov 7 15:23:41 EST 2006


getQueryResults behavior: return null 
--------------------------------------

                 Key: JBRULES-544
                 URL: http://jira.jboss.com/jira/browse/JBRULES-544
             Project: JBoss Rules
          Issue Type: Feature Request
      Security Level: Public (Everyone can see)
          Components: Reteoo
    Affects Versions: 3.0.4
            Reporter: Edson Tirelli
         Assigned To: Edson Tirelli
             Fix For: 3.0.5, 3.1-m1


AS REPORTED BY GEOFFREY DE SMET:
---------------------------------------------------------
Thanks Edson for fixing the getQueryResults() method in JBRULES-539.
I found something interesting I'd like to bring under discussion:

WorkingMemory.getQueryResults() returns null when:

- no such query exists in the drl's. I would have expected an IllegalArgumentException, in the spirit of fail-fast,
but it's not that big a deal.

- but it also returns null when the query has 0 results.
I would have expected a QueryResults instance with .size() == 0.
It seems inconsistent with WorkingMemory.getObjects(X.class) which does return an empty list, instead of null.

[tested on the branch for 3.0.x for Rete]

What do you think?

-- 
With kind regards,
Geoffrey De Smet 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list