[jboss-jira] [JBoss JIRA] Created: (JBMESSAGING-637) JDBCChannelMapper and JDBCPersistenceManager do not close Statements

[jivkoto (JIRA)]

JDBCChannelMapper and JDBCPersistenceManager do not close Statements
--------------------------------------------------------------------

                 Key: JBMESSAGING-637
                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-637
             Project: JBoss Messaging
          Issue Type: Bug
          Components: Messaging Core
    Affects Versions: 1.2.0.Alpha2, 1.0.1.GA
         Environment: JBoss 4.0.4 GA, Windows XP + SP2, MS SQL SERVER 2000
            Reporter: jivkoto
         Assigned To: Ovidiu Feodorov


After starting jboss-messaging configured to use MS SQLServer2000 there a lots of mumbles that there are lots of statements that are left open. 

10:38:32,265 WARN  [WrappedConnection] Closing a statement you left open, please do your own housekeeping
java.lang.Throwable: STACKTRACE

The places where the statements are left open are:
org.jboss.jms.server.plugin.JDBCChannelMapper#createSchema
org.jboss.messaging.core.plugin.JDBCPersistenceManager#createSchema

Even if my report is for jboss-messaging 1.0.1.GA I checked the related places in jboss-messaging-1.2.0.Alpha2. And there is code such as conn.createStatement().executeUpdate(statement) too.

The places I found it are:
org.jboss.jms.server.plugin.JDBCJMSUserManager#insertUserRoleData
org.jboss.messaging.core.plugin.JDBCSupport#createSchema

Please close the statements. I hope that what I am reporting is useful for you. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira