[jboss-jira] [JBoss JIRA] Created: (JBCACHE-824) Don't call Channel.getView() in viewAccepted() callback

Brian Stansberry (JIRA) jira-events at jboss.com
Sun Oct 29 22:49:41 EST 2006


Don't call Channel.getView() in viewAccepted() callback
-------------------------------------------------------

                 Key: JBCACHE-824
                 URL: http://jira.jboss.com/jira/browse/JBCACHE-824
             Project: JBoss Cache
          Issue Type: Task
      Security Level: Public (Everyone can see)
            Reporter: Brian Stansberry
         Assigned To: Brian Stansberry
             Fix For: 1.4.1.GA, 2.0.0.GA


In the viewAccepted() callback we call determineCoordinator(), which in turn calls Channel.getView().  This is wacky, since viewAccepted() is passed the view and thus can directly determine if the node is coordinator.  The call into Channel.getView() forces an ugly workaround in JChannel (see internal comments in JChannel in release 2.4).

While fixing this I'll tighten up how the determination of the coordinator works outside of viewAccepted.  Get rid of Channel.getView() call.  Basically if we haven't gotten a view wait on the members field, and when notified by viewAccepted() determine if coord based on the members field.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list