[jboss-jira] [JBoss JIRA] Commented: (JBCACHE-815) Eliminate need for jboss-serialization.jar if it's not used

[Clebert Suconic (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBCACHE-815?page=comments#action_12346028 ] 
            
Clebert Suconic commented on JBCACHE-815:
-----------------------------------------

You don't need to change JBossSerialization for this...

JBossSerialization already has a support for changing classLoader and I don't see a way to put this specific behavior on read for JBossSerialization. A inner class the way you have done is the best way to do so.


However I have provided a patch that would avoid loading JBossSerialization if not loaded. A simple refactoring in your factories.

I will be uploading 4 classes and 1 test.

(You will only need to add /* RedHat/JBoss copyright ad stuff on headers */ :-) )

> Eliminate need for jboss-serialization.jar if it's not used
> -----------------------------------------------------------
>
>                 Key: JBCACHE-815
>                 URL: http://jira.jboss.com/jira/browse/JBCACHE-815
>             Project: JBoss Cache
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Replication
>    Affects Versions: 1.4.0.GA, 1.4.0.SP1
>            Reporter: Brian Stansberry
>         Assigned To: Manik Surtani
>            Priority: Minor
>             Fix For: 2.2.0.GA
>
>         Attachments: JavaSerializationFactoryImpl.java, JBossSerializationFactoryImpl.java, ObjectSerializationFactory.java, SerializationFactory.java, Test.java
>
>
> If we're going to stick making use of JBoss serialization a configurable option, we should refactor ObjectSerializationFactory so no jboss-serialization classes are loaded if it's not used. Allows users to drop one more jar from their footprint.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira