[jboss-jira] [JBoss JIRA] Updated: (JBAS-3628) Invalid fix for JBAS-3573

[Luc Texier (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBAS-3628?page=all ]

Luc Texier updated JBAS-3628:
-----------------------------

    Fix Version/s: JBossAS-5.0.0.Beta
      Description: 
in case of an exception, both  a PostCommit Task and a PostRollback Task should be added

         try
         {
            if (m.isPersistent())
               server.getPersistenceManager().remove(m, txId);
         }
         catch (Throwable t)
         {
            // Something is wrong with the persistence manager,
            // force a NACK with a rollback/error
            Runnable task = new RestoreMessageTask(m);
            TxManager txManager = server.getPersistenceManager().getTxManager();
+          txManager.addPostCommitTask(txId, task);            
            txManager.addPostRollbackTask(txId, task);
            SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m, t);
         }

  was:

in case of an exception, both  a PostCommit Task and a PostRollback Task should be added

         try
         {
            if (m.isPersistent())
               server.getPersistenceManager().remove(m, txId);
         }
         catch (Throwable t)
         {
            // Something is wrong with the persistence manager,
            // force a NACK with a rollback/error
            Runnable task = new RestoreMessageTask(m);
            TxManager txManager = server.getPersistenceManager().getTxManager();
+          txManager.addPostCommitTask(txId, task);            
            txManager.addPostRollbackTask(txId, task);
            SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m, t);
         }


> Invalid fix for JBAS-3573
> -------------------------
>
>                 Key: JBAS-3628
>                 URL: http://jira.jboss.com/jira/browse/JBAS-3628
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>            Reporter: Luc Texier
>         Assigned To: Luc Texier
>             Fix For: JBossAS-5.0.0.Beta, JBossAS-4.0.5.GA
>
>
> in case of an exception, both  a PostCommit Task and a PostRollback Task should be added
>          try
>          {
>             if (m.isPersistent())
>                server.getPersistenceManager().remove(m, txId);
>          }
>          catch (Throwable t)
>          {
>             // Something is wrong with the persistence manager,
>             // force a NACK with a rollback/error
>             Runnable task = new RestoreMessageTask(m);
>             TxManager txManager = server.getPersistenceManager().getTxManager();
> +          txManager.addPostCommitTask(txId, task);            
>             txManager.addPostRollbackTask(txId, task);
>             SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m, t);
>          }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira