[jboss-jira] [JBoss JIRA] Created: (JGRP-300) NAKACK.send() doesn't need to be synchronized

[Bela Ban (JIRA)]

NAKACK.send() doesn't need to be synchronized
---------------------------------------------

                 Key: JGRP-300
                 URL: http://jira.jboss.com/jira/browse/JGRP-300
             Project: JGroups
          Issue Type: Task
    Affects Versions: 2.3 SP1
            Reporter: Bela Ban
         Assigned To: Bela Ban
            Priority: Minor
             Fix For: 2.4


NAKACK.send() currently calls passDown(evt) in a synchronized(sent_msgs) statement. However, this is not necessary (contrary to handleMessage() which needs to pass messages up in the order of sequence numbers) because messages can be sent un-ordered. The receivers will order the messages anyway, so if we sent 1,3,2,4 due to thread premption, the receivers will order them and deliver them as 1,2,3,4.
BENEFIT: the less synchronization, the less probability of deadlocks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira